Make the requiredProjectId work with the online editor#4081
Make the requiredProjectId work with the online editor#4081paulkaplan merged 2 commits intoscratchfoundation:developfrom
Conversation
|
hmm, travis is failing in a way that may be legit, on "Load a project by ID directly through url" |
|
LMK if you want me to take a look at the overlap with project-state |
|
@ericrosenbaum that is suspicious, although it is running locally for me, so I'm going to rerun it. The code changes were only in the tips library, so although project loading is involved, none of that code should be being touched. |
paulkaplan
force-pushed
the
more-beefers
branch
from
8237bd2 to
7da26da
Compare
|
@ericrosenbaum confirmed that was a problem with project server, not us. I also implemented a confirm to prevent you from leaving a project with unsaved changes. It isn't great, but I figure anything is better than losing work. |
paulkaplan
force-pushed
the
more-beefers
branch
2 times, most recently
from
23bcaa9 to
8954b6e
Compare
|
@chrisgarrity this can be reviewed now. It keeps the window opening behavior, but changes it to open the project at |
paulkaplan
force-pushed
the
more-beefers
branch
from
8954b6e to
910d2b3
Compare
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
One little change: the new URL should open the editor.
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
Looks good. I uploaded a copy of the project to my local copy. Replacing the project id with the one on my local one worked great.
4 participants
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
If you aren't on the tutorial project, open it in a new tab in a way that'll work in production